stevenzwu commented on code in PR #13245:
URL: https://github.com/apache/iceberg/pull/13245#discussion_r2179196428
##########
api/src/main/java/org/apache/iceberg/OverwriteFiles.java:
##########
@@ -75,6 +77,19 @@ public interface OverwriteFiles extends
SnapshotUpdate<OverwriteFiles> {
*/
OverwriteFiles deleteFile(DataFile file);
+ /**
+ * Deletes a set of data files from the table with their respective delete
files.
+ *
+ * @param dataFilesToDelete the data files to be deleted from the table
+ * @param deleteFilesToDelete the delete files corresponding to the data
files to be deleted from
+ * the table
+ * @return this for method chaining
+ */
+ default OverwriteFiles deleteFiles(
Review Comment:
that is fair to be consistent with the existing method.
But I still feel `removeFile` is a better name than `deleteFile` as
deleteFile can be associated with just the position/equality delete file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
