yguy-ryft commented on code in PR #13432:
URL: https://github.com/apache/iceberg/pull/13432#discussion_r2179400351
##########
docs/docs/configuration.md:
##########
@@ -74,8 +74,8 @@ Iceberg tables support table properties to configure table
behavior, like the de
| write.merge.distribution-mode | (not set)
| Defines distribution of write merge data
|
| write.wap.enabled | false
| Enables write-audit-publish writes
|
| write.summary.partition-limit | 0
| Includes partition-level summary stats in snapshot summaries if the
changed partition count is less than this limit
|
-| write.metadata.delete-after-commit.enabled | false
| Controls whether to delete the oldest **tracked** version metadata
files after commit
|
-| write.metadata.previous-versions-max | 100
| The max number of previous version metadata files to keep before
deleting after commit
|
+| write.metadata.previous-versions-max | 100
| The max number of previous version metadata files to track
|
Review Comment:
It does - this is exactly the confusing part that i'm trying to improve with
the doc changes
- `previous-versions-max` is working anyway, and it just **untracks** the
files from the newest metadata file
- `delete-after-commit` says that the writer won't only **untrack** the old
metadata file, but will also **delete** it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
