mickjermsurawong-stripe commented on pull request #1531: URL: https://github.com/apache/iceberg/pull/1531#issuecomment-703048101
@rdblue, ah thank you for the feedback on test! I guess the complicated test here is the artifacts of me trying to test the logic in my first data localization feature. I created a separate test as suggested; I made use of the existing `TableTestBase` and construct tests based on `table.locationProvider()` instead of its underlying operations (though that also directly delegates to the ops). I also addressed feedback on error message. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
