RussellSpitzer commented on code in PR #12450: URL: https://github.com/apache/iceberg/pull/12450#discussion_r2180372970
########## api/src/main/java/org/apache/iceberg/actions/ComputePartitionStats.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.PartitionStatisticsFile; + +/** + * An action that computes and writes the partition statistics of an Iceberg table. Current snapshot + * is used by default. + */ +public interface ComputePartitionStats + extends Action<ComputePartitionStats, ComputePartitionStats.Result> { Review Comment: I think the argument here I feel strongest about is the mixing of options that are invalid that we can only determine that at runtime. IMHO, we should aim to have apis where there as few gotchas as possible. If the API can't hide the fact that there are two very different things happening under the hood I don't think they should be combined. So I think we could keep them in the same action but only if we have the apis a little better segregated. Perhaps instead of "columns" you have something like ".withTableLevelNDVs("columns").withPartitionStats()" These are breaking changes I know, but they make clear that there are two different mutually exclusive things happening. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
