amogh-jahagirdar commented on code in PR #13448:
URL: https://github.com/apache/iceberg/pull/13448#discussion_r2180778412
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
##########
@@ -316,6 +316,18 @@ public void testConflictingColumns() {
sql("SELECT _spec_id, _partition, _renamed_spec_id FROM %s",
TABLE_NAME));
}
+ @TestTemplate
Review Comment:
I believe we'll need to make id a required field up above (noticed it when
comparing the diff) since that's requirement to be an identifier field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
