stevenzwu commented on code in PR #13425:
URL: https://github.com/apache/iceberg/pull/13425#discussion_r2180792043
##########
core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java:
##########
@@ -387,16 +410,22 @@ public void testPartitionStats() throws Exception {
0,
null,
snapshot1.timestampMillis(),
- snapshot1.snapshotId()));
+ snapshot1.snapshotId(),
+ 0));
+
+ DeleteFile posDeletes = null;
+ DeleteFile deleteVectors = null;
+ if (formatVersion == 3) {
Review Comment:
maybe change to `>= 3`
##########
core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java:
##########
@@ -425,20 +455,22 @@ public void testPartitionStats() throws Exception {
0,
null,
snapshot1.timestampMillis(),
- snapshot1.snapshotId()),
+ snapshot1.snapshotId(),
+ 0),
Tuple.tuple(
partitionRecord(partitionType, "bar", "A"),
0,
3 * dataFile3.recordCount(),
3,
3 * dataFile3.fileSizeInBytes(),
- posDeletes.recordCount(),
- 1,
+ formatVersion == 3 ? deleteVectors.recordCount() :
posDeletes.recordCount(),
Review Comment:
not friendly for future version 4. maybe use
`ContentFileUtil.isDV(DeleteFile)`
Also do we need two different variables earlier?
```
DeleteFile posDeletes = null;
DeleteFile deleteVectors = null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
