mwa28 commented on issue #2166:
URL: 
https://github.com/apache/iceberg-python/issues/2166#issuecomment-3029183742

   > Hey [@mwa28](https://github.com/mwa28) nice find! Seems to be an issue 
with PyIceberg. The Java library throws a validation exception when dropping a 
column that is used for the sort order.
   > 
   > 
https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TestSortOrder.java#L304-L314
   
   That's actually really interesting to know !
   
   > [@geruh](https://github.com/geruh) thanks for linking -- I think we should 
look at that test suite and see what other operations throw errors and 
incorporate those into the test suite here! [@mwa28](https://github.com/mwa28) 
what do you think?
   
   Yes it seems on this file alone there are 7 occurrences of 
`assertThatThrownBy` and it would be much smarter to do it this way. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to