RussellSpitzer commented on a change in pull request #1421:
URL: https://github.com/apache/iceberg/pull/1421#discussion_r499681020
##########
File path: core/src/main/java/org/apache/iceberg/IncrementalDataTableScan.java
##########
@@ -106,7 +106,7 @@ protected TableScan newRefinedScan(TableOperations ops,
Table table, Schema sche
return new IncrementalDataTableScan(ops, table, schema, context);
}
- private static List<Snapshot> snapshotsWithin(Table table, long
fromSnapshotId, long toSnapshotId) {
+ public static List<Snapshot> snapshotsWithin(Table table, long
fromSnapshotId, long toSnapshotId) {
Review comment:
We only really need this method to be public so we can determine the
snapshots to be used in the scan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
