nastra commented on code in PR #12562:
URL: https://github.com/apache/iceberg/pull/12562#discussion_r2182379450
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##########
@@ -156,19 +156,28 @@ public OAuth2Util.AuthSession tableSession(
@Override
public void close() {
- try {
+ AuthManagerSessionCache<String, OAuth2Util.AuthSession> cache =
sessionCache;
+ this.sessionCache = null;
+ try (cache) {
super.close();
- } finally {
- AuthSessionCache cache = sessionCache;
- this.sessionCache = null;
- if (cache != null) {
- cache.close();
- }
}
}
+ /**
+ * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
#newAuthSessionCache(String,
+ * Map)}
+ */
+ @Deprecated
protected AuthSessionCache newSessionCache(String managerName, Map<String,
String> properties) {
- return new AuthSessionCache(managerName, sessionTimeout(properties));
Review Comment:
What if people didn't override `newSessionCache` and just upgrade Iceberg
and realize that this method now returns `null`? Not everyone will be using
`newAuthSessionCache` immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
