Guosmilesmile commented on code in PR #13426: URL: https://github.com/apache/iceberg/pull/13426#discussion_r2184914379
########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/actions/ExpireSnapshotsAction.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.actions; + +import java.time.Duration; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.flink.TableLoader; +import org.apache.iceberg.flink.maintenance.api.ExpireSnapshots; + +public class ExpireSnapshotsAction + extends BaseTableMaintenanceAction<ExpireSnapshotsAction, ExpireSnapshots.Builder> { + + public ExpireSnapshotsAction( + StreamExecutionEnvironment env, TableLoader tableLoader, long triggerTimestamp) { + super(env, tableLoader, triggerTimestamp, ExpireSnapshots::builder); + } + + public ExpireSnapshotsAction(StreamExecutionEnvironment env, TableLoader tableLoader) { + super(env, tableLoader, ExpireSnapshots::builder); + } + + /** + * The snapshots older than this age will be removed. + * + * @param newMaxSnapshotAge of the snapshots to be removed + */ + public ExpireSnapshotsAction maxSnapshotAge(Duration newMaxSnapshotAge) { + builder().maxSnapshotAge(newMaxSnapshotAge); + return this; + } Review Comment: Changing to use a parameter has indeed made the code much cleaner and simpler. One change is that the action’s input parameters need to be modified, which may cause some conflicts when replacing the calls to the existing action. However, I prefer to use the new approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
