nt-tryg opened a new issue, #1487:
URL: https://github.com/apache/iceberg-rust/issues/1487

   ### Apache Iceberg Rust version
   
   None
   
   ### Describe the bug
   
   According to the iceberg spec documentation the field "identifier-field-ids" 
is an optional field.
   See: https://iceberg.apache.org/spec/#schemas
   
   But the type definition for it in rust is not marked as an Option.
   See: 
https://github.com/apache/iceberg-rust/blob/main/crates/iceberg/src/spec/schema/mod.rs#L61C27-L61C40
   
   This is causing a bug in Lakekeeper making it return "identifier-field-ids: 
null" in response for metadata about a table where "identifier-field-ids" is 
not set.
   
   
   Should be an easy change to comply with the official spec documentation, I 
can prepare a merge request for this.
   
   ### To Reproduce
   
   Try to query an iceberg table from duckdb with the iceberg extension with 
lakekeeper as rest catalog and where "identifier-field-ids" is not set.
   
   ### Expected behavior
   
   If "identifier-field-ids" is not set in the metadata, it should not have the 
field in the json representation.
   
   ### Willingness to contribute
   
   I can contribute a fix for this bug independently


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to