kevinjqliu commented on PR #13357: URL: https://github.com/apache/iceberg/pull/13357#issuecomment-3039406763
Hey @Claudenw, thanks for the PR here! I want to verify my understanding of the underlying issue. It looks like we already fixed the underlying race condition when multiple clients are trying to initialize the same JDBC catalog (https://github.com/apache/iceberg/pull/13345). Is this PR intended to address the issue https://github.com/apache/iceberg/issues/13356? If so, lets update the PR description. Is the intent here to load the catalog at the connector initialization to **ensure that the catalog itself is properly configured**? If so, I feel like this puts extra burden on the connector. Ideally, the connector should not worry about the catalog and its state. The connector should just connect to the catalog and perform subsequent operations. I feel a better approach is to have the catalog pre-configured before the setting up the connector. Perhaps we can update the [kakfa-connect docs](https://iceberg.apache.org/docs/latest/kafka-connect/#iceberg-catalog-configuration) to call that out. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
