ZENOTME opened a new pull request, #1490:
URL: https://github.com/apache/iceberg-rust/pull/1490

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   
   ## What changes are included in this PR?
   
   <!--
   Provide a summary of the modifications in this PR. List the main changes 
such as new features, bug fixes, refactoring, or any other updates.
   -->
   
   This PR refine the interface of SnapshotProducer:
   1. include the table in SnapshotProducer rather than pass using function 
param
   2. add SnapshotProducer as param for ManifestProcess, 
SnapshotProduceOperation
   
   I find that it would convenient when working on merge append: 
ManifestProcess and SnapshotProduceOperation can be consider as custom 
extension for SnapshotProducer and they would reuse SnapshotProducer as for 
common usage. So we should include it in their function param. At the same 
time, include Table in SnapshotProducer make thing easier they can use 
SnapshotProducer diretcly.
   
   ## Are these changes tested?
   
   <!--
   Specify what test covers (unit test, integration test, etc.).
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to