elphastori commented on issue #13388: URL: https://github.com/apache/iceberg/issues/13388#issuecomment-3045161804
> Since we'd want to create `nyc.entries` as a valid table, we probably would want to add a case [here](https://github.com/apache/iceberg/blob/f3b198de2304c01af9beedf47fcc6edfe8f4f1c7/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L406-L410) for when `baseIdent` is empty and still set `loadedIdent = baseIdent` Agreed. In the PR I raised #13389 , I opted to throw the original exception. I don't think we would still need to worry about `loadedIdent` with this implementation but I might be missing something. > When baseIdent is empty, we cannot call `loadInternal`. So maybe its a good idea to validate the identifier input to loadInternal too It's a great idea. I'll add the identifier validation to `loadInternal` in a new commit. > Normally, metadata table is addressed with 3 parts. For example, `nyc.tbl.entries`. `nyc` is namespace, `tbl` is the table name, and `entries` is the metadata table name. This is especially true for catalogs that do not support empty namespaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
