nastra commented on code in PR #13222:
URL: https://github.com/apache/iceberg/pull/13222#discussion_r2190684128
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -155,6 +161,11 @@ void caseSensitive(boolean newCaseSensitive) {
this.caseSensitive = newCaseSensitive;
}
+ protected void removeDanglingDeletesFor(Set<DataFile> dataFiles) {
Review Comment:
@stevenzwu sorry I forgot to reply to this comment. I took a look at this
last week but this makes the code longer than necessary, because now you need
to define accessor methods (due to checkstyle) so that you can properly
access/set `removedDataFilePaths` in the subclass. I would prefer to keep it
as-is but I added a comment to make it hopefully clearer that this is only
being used in `DeleteManifestFilterManager`.
Let me know if you feel strongly about this or whether this approach is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
