danielcweeks commented on code in PR #13215:
URL: https://github.com/apache/iceberg/pull/13215#discussion_r2192968586
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -76,15 +80,25 @@ public abstract class S3V4RestSignerClient
private static final String SCOPE = "sign";
- @SuppressWarnings("immutables:incompat")
- private volatile AuthManager authManager;
+ @SuppressWarnings({"immutables:incompat", "VisibilityModifier"})
+ @VisibleForTesting
+ static volatile AuthManager authManager;
@SuppressWarnings({"immutables:incompat", "VisibilityModifier"})
@VisibleForTesting
static volatile RESTClient httpClient;
- @SuppressWarnings("immutables:incompat")
- private volatile AuthSession authSession;
+ @SuppressWarnings("ShutdownHook")
+ private static void installShutdownHook() {
Review Comment:
Are we sure this is safe? It feels like we could be trading one problem for
another because if an engine loads tasks in separate classloaders, we might
have an issue with shutdown hooks piling up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
