mickjermsurawong-stripe commented on a change in pull request #1531:
URL: https://github.com/apache/iceberg/pull/1531#discussion_r499880316
##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -45,6 +50,53 @@ public static LocationProvider locationsFor(String location,
Map<String, String>
}
}
+ private static LocationProvider dynamicallyLoadLocationProvider(String
location, Map<String, String> properties) {
+ String impl = properties.get(TableProperties.WRITE_LOCATION_PROVIDER_IMPL);
+ Optional<DynConstructors.Ctor<LocationProvider>> noArgConstructor =
findConstructor(() ->
+ DynConstructors.builder(LocationProvider.class)
+ .impl(impl).build()
+ );
+ Optional<DynConstructors.Ctor<LocationProvider>> twoArgConstructor =
Optional.empty();
Review comment:
thanks for the explanation here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
