pvary commented on pull request #1505: URL: https://github.com/apache/iceberg/pull/1505#issuecomment-703903819
> If it's a Spark bug, then let's just add an `Assume` for the failing test to exclude it when the catalog is `spark_catalog`. Thanks for looking into it further, @pvary! Currently in our spark tests we set `engine.hive.enabled` to `false` (and also we default to there so no breaking change in the release). That is way with the code in this PR does not trigger the issue. So I think we are good on this. Unless we want specific tests in spark sql to have `engine.hive.enabled` set to `true` and test this code path as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
