liamzwbao commented on code in PR #13324:
URL: https://github.com/apache/iceberg/pull/13324#discussion_r2196215334
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java:
##########
@@ -400,4 +400,19 @@ public void testUnsupportedReadsForParquetV2() throws
Exception {
.hasMessageStartingWith("Cannot support vectorized reads for column")
.hasMessageEndingWith("Disable vectorized reads to read this
table/file");
}
+
+ @Test
+ public void testUuidReads() throws Exception {
+ // Just one row to maintain dictionary encoding
+ int numRows = 1;
+ Schema schema = new Schema(optional(100, "uuid", Types.UUIDType.get()));
+
+ File dataFile = File.createTempFile("junit", null, temp.toFile());
+ assertThat(dataFile.delete()).as("Delete should succeed").isTrue();
Review Comment:
Took a look at the issue, `@TempDir` make sure each test get a unique
directory so multiple tests won't affect each other. However, the reason these
tests need to manually delete the directory is that `@TempDir` always creates
the directory before the test starts, and getParquetWriter throws an exception
if the target folder already exists.
What we actually need here is just a randomly generated path without
creating anything at that location. Unfortunately, `@TempDir` doesn’t currently
support that level of control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
