nastra commented on code in PR #13509:
URL: https://github.com/apache/iceberg/pull/13509#discussion_r2197234718
##########
api/src/main/java/org/apache/iceberg/actions/ExpireSnapshots.java:
##########
@@ -97,6 +97,19 @@ public interface ExpireSnapshots extends
Action<ExpireSnapshots, ExpireSnapshots
*/
ExpireSnapshots executeDeleteWith(ExecutorService executorService);
+ /**
+ * Expires unused table metadata such as partition specs and schemas.
+ *
+ * <p>Metadata such as partition specs or schemas that are no longer
referenced by snapshots will
+ * be removed.
+ *
+ * <p>Identical to {@link
org.apache.iceberg.ExpireSnapshots#cleanExpiredMetadata(boolean)}
+ *
+ * @param clean remove unused partition specs, schemas, or other metadata
when true
+ * @return this for method chaining
+ */
+ ExpireSnapshots cleanExpiredMetadata(boolean clean);
Review Comment:
this should throw an UOE so that we don't have to break the API and don't
need the RevAPI exception:
https://iceberg.apache.org/contribute/#adding-new-functionality-without-breaking-apis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
