stubz151 commented on code in PR #13387:
URL: https://github.com/apache/iceberg/pull/13387#discussion_r2200312436


##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestFlakyS3InputStream.java:
##########
@@ -138,6 +230,14 @@ private S3ClientWrapper flakyStreamClient(AtomicInteger 
counter, IOException fai
     return flakyClient;
   }
 
+  private S3AsyncClientWrapper flakyStreamAsyncClient(AtomicInteger counter, 
IOException failure) {
+    S3AsyncClientWrapper flakyClient = spy(new 
S3AsyncClientWrapper(s3AsyncClient()));
+    doAnswer(invocation -> new FlakyInputStream(invocation.callRealMethod(), 
counter, failure))

Review Comment:
   [from testing] I'm not sure if this wrapper is 100% right. I am seeing cast 
exceptions will look in to this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to