DerGut commented on PR #1496: URL: https://github.com/apache/iceberg-rust/pull/1496#issuecomment-3066936928
Thanks a lot for chiming in @sdd! I think using `metrics` and `tracing` directly instead makes a lot of sense. They are generally about as pluggable as the reporting interface is and I can't think of an implementation that wouldn't work either way. I have one concern though: Emitting metrics straight from the implementation effectively binds us to a choice of metric names. To be able to aggregate metrics across language clients, I think we should agree on a naming that works for other implementations too. I've been meaning to start a similar discussion in [apache/iceberg-go](https://github.com/apache/iceberg-go) and [apache/iceberg-python](https://github.com/apache/iceberg-python) too, so let me go ahead and do this now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
