wgtmac commented on code in PR #144:
URL: https://github.com/apache/iceberg-cpp/pull/144#discussion_r2206135898
##########
src/iceberg/table_metadata.h:
##########
@@ -123,12 +123,17 @@ struct ICEBERG_EXPORT TableMetadata {
/// \brief Get the current schema, return NotFoundError if not found
Result<std::shared_ptr<Schema>> Schema() const;
+ /// \brief Get the current schema by ID, return NotFoundError if not found
Review Comment:
What about adding some test cases for these new functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
