gty404 commented on code in PR #143: URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2206233437
########## src/iceberg/manifest_reader_internal.cc: ########## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "manifest_reader_internal.h" + +#include <array> + +#include <nanoarrow/nanoarrow.h> + +#include "iceberg/arrow_c_data_guard_internal.h" +#include "iceberg/manifest_entry.h" +#include "iceberg/manifest_list.h" +#include "iceberg/schema.h" +#include "iceberg/schema_internal.h" +#include "iceberg/type.h" +#include "iceberg/util/macros.h" + +namespace iceberg { + +#define NANOARROW_RETURN_IF_NOT_OK(status, error) \ + if (status != NANOARROW_OK) [[unlikely]] { \ + return InvalidArrowData("Nanoarrow error: {}", error.message); \ + } + +Status ParsePartitionFieldSummaryList(ArrowArrayView* view_of_column, + std::vector<ManifestFile>& manifest_files) { + auto manifest_count = view_of_column->length; + // view_of_column is list<struct<PartitionFieldSummary>> + if (view_of_column->storage_type != ArrowType::NANOARROW_TYPE_LIST) { + return InvalidManifestList("partitions field should be a list."); + } + auto view_of_list_iterm = view_of_column->children[0]; + // view_of_list_iterm is struct<PartitionFieldSummary> + if (view_of_list_iterm->storage_type != ArrowType::NANOARROW_TYPE_STRUCT) { + return InvalidManifestList("partitions list field should be a list."); + } + if (view_of_list_iterm->n_children != 4) { + return InvalidManifestList("PartitionFieldSummary should have 4 fields."); + } + if (view_of_list_iterm->children[0]->storage_type != ArrowType::NANOARROW_TYPE_BOOL) { + return InvalidManifestList("contains_null should have be bool type column."); + } + auto contains_null = view_of_list_iterm->children[0]; + if (view_of_list_iterm->children[1]->storage_type != ArrowType::NANOARROW_TYPE_BOOL) { + return InvalidManifestList("contains_nan should have be bool type column."); + } + auto contains_nan = view_of_list_iterm->children[1]; + if (view_of_list_iterm->children[2]->storage_type != ArrowType::NANOARROW_TYPE_BINARY) { + return InvalidManifestList("lower_bound should have be binary type column."); + } + auto lower_bound_list = view_of_list_iterm->children[2]; + if (view_of_list_iterm->children[3]->storage_type != ArrowType::NANOARROW_TYPE_BINARY) { + return InvalidManifestList("upper_bound should have be binary type column."); + } + auto upper_bound_list = view_of_list_iterm->children[3]; + for (int64_t manifest_idx = 0; manifest_idx < manifest_count; manifest_idx++) { + auto offset = ArrowArrayViewListChildOffset(view_of_column, manifest_idx); + auto next_offset = ArrowArrayViewListChildOffset(view_of_column, manifest_idx + 1); + // partitions from offset to next_offset belongs to manifest_idx + auto& manifest_file = manifest_files[manifest_idx]; + for (int64_t partition_idx = offset; partition_idx < next_offset; partition_idx++) { + PartitionFieldSummary partition_field_summary; + if (!ArrowArrayViewIsNull(contains_null, partition_idx)) { + partition_field_summary.contains_null = + ArrowArrayViewGetIntUnsafe(contains_null, partition_idx); + } + if (!ArrowArrayViewIsNull(contains_nan, partition_idx)) { + partition_field_summary.contains_nan = + ArrowArrayViewGetIntUnsafe(contains_nan, partition_idx); + } + if (!ArrowArrayViewIsNull(lower_bound_list, partition_idx)) { + auto buffer = ArrowArrayViewGetBytesUnsafe(lower_bound_list, partition_idx); + partition_field_summary.lower_bound = std::vector<uint8_t>( + buffer.data.as_char, buffer.data.as_char + buffer.size_bytes); + } + if (!ArrowArrayViewIsNull(upper_bound_list, partition_idx)) { + auto buffer = ArrowArrayViewGetBytesUnsafe(upper_bound_list, partition_idx); + partition_field_summary.upper_bound = std::vector<uint8_t>( + buffer.data.as_char, buffer.data.as_char + buffer.size_bytes); + } + + manifest_file.partitions.emplace_back(partition_field_summary); + } + } + return {}; +} + +Result<std::vector<ManifestFile>> ParseManifestListEntry(ArrowSchema* schema, + ArrowArray* array_in, + const Schema& iceberg_schema) { + if (schema->n_children != array_in->n_children) { + return InvalidManifestList("Columns size not match between schema:{} and array:{}", + schema->n_children, array_in->n_children); + } + if (iceberg_schema.fields().size() != array_in->n_children) { + return InvalidManifestList("Columns size not match between schema:{} and array:{}", + iceberg_schema.fields().size(), array_in->n_children); + } + + ArrowError error; + ArrowArrayView array_view; + auto status = ArrowArrayViewInitFromSchema(&array_view, schema, &error); + NANOARROW_RETURN_IF_NOT_OK(status, error); + internal::ArrowArrayViewGuard view_guard(&array_view); + status = ArrowArrayViewSetArray(&array_view, array_in, &error); + NANOARROW_RETURN_IF_NOT_OK(status, error); + status = ArrowArrayViewValidate(&array_view, NANOARROW_VALIDATION_LEVEL_FULL, &error); + NANOARROW_RETURN_IF_NOT_OK(status, error); + + std::vector<ManifestFile> manifest_files; + manifest_files.resize(array_in->length); + + for (int64_t idx = 0; idx < array_in->n_children; idx++) { + const auto& field = iceberg_schema.GetFieldByIndex(idx); + if (!field.has_value()) { + return InvalidSchema("Field index {} is not found in schema", idx); + } + auto field_name = field.value().get().name(); + bool required = !field.value().get().optional(); + auto view_of_column = array_view.children[idx]; + +#define PARSE_PRIMITIVE_FIELD(item, type) \ + for (size_t row_idx = 0; row_idx < view_of_column->length; row_idx++) { \ + if (!ArrowArrayViewIsNull(view_of_column, row_idx)) { \ Review Comment: To address the issue of compatibility between versions, I understand that there are two approaches: 1. The io layer is only responsible for executing deserialization accurately without making excessive assumptions. Compatibility is handled by the upper layer, as it has more information to assist in interpreting missing fields, such as the table format version existing in the table metadata. 2. During the underlying deserialization, supplement missing fields to be transparent to the upper layer. This requires that new fields all have reasonable default values, so that the upper layer always sees the latest version of the meta. Both approaches require that the supplementation of missing values be as converged as possible to the same place, to avoid each logic that consumes the field needing to handle compatibility issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
