kevinjqliu commented on PR #2090: URL: https://github.com/apache/iceberg-python/pull/2090#issuecomment-3071813000
oops, im late to the party. > I'd prefer to avoid mock and rely on the integration tests that we have with the [rest](https://github.com/apache/iceberg-python/blob/41ff734aa68beda54775a810599aae1552162beb/dev/docker-compose-integration.yml#L42) and [hive](https://github.com/apache/iceberg-python/blob/41ff734aa68beda54775a810599aae1552162beb/dev/docker-compose-integration.yml#L89) image. +1 for these integration tests, it would be great to use the actual catalog implementations instead of mocks. > What's up with this? https://github.com/apache/iceberg-python/blob/main/pyiceberg/catalog/sql.py#L100 NAMESPACE_MINIMAL_PROPERTIES Are those used anywhere? thats an implementation detail :) > Just want to see everything hopefully work i think we can start with `rest`, `hive`, and `sqlite`. Those 3 are fairly straight forward. `glue` and `dynamodb` catalogs are difficult to setup as integration tests. We can first expand to more tests and then add more catalog implementations. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
