aammar5 commented on code in PR #2143:
URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2211014819
##########
pyiceberg/table/inspect.py:
##########
@@ -681,6 +681,32 @@ def all_manifests(self) -> "pa.Table":
)
return pa.concat_tables(manifests_by_snapshots)
+ def _all_known_files(self) -> dict[str, set[str]]:
+ """Get all the known files in the table.
+
+ Returns:
+ dict of {file_type: set of file paths} for each file type.
+ """
+ snapshots = self.tbl.snapshots()
+
+ _all_known_files = {}
+ _all_known_files["manifests"] =
set(self.all_manifests(snapshots)["path"].to_pylist())
+ _all_known_files["manifest_lists"] = {snapshot.manifest_list for
snapshot in snapshots}
+ _all_known_files["statistics"] = {statistic.statistics_path for
statistic in self.tbl.metadata.statistics}
+
+ metadata_files = {entry.metadata_file for entry in
self.tbl.metadata.metadata_log}
Review Comment:
What's the reason to not expire the `metadata_log` files? It seems this will
cause them to remain even when doing an expiry after a `table.delete()`, also
this function doesn't seem to be be used anywhere here? seems to be used by
#1958?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
