nastra commented on code in PR #13589:
URL: https://github.com/apache/iceberg/pull/13589#discussion_r2213437792
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -256,11 +256,11 @@ private CloseableIterable<ManifestEntry<F>>
entries(boolean onlyLive) {
}
private boolean hasRowFilter() {
- return rowFilter != null && rowFilter != Expressions.alwaysTrue();
Review Comment:
this has been already statically imported in this class and from what I can
tell the `rowFilter` and the `partFilter` can never be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
