marton-bod commented on pull request #1478: URL: https://github.com/apache/iceberg/pull/1478#issuecomment-704961465
@rdblue Thanks for the suggestion! As per that, I've changed the code to create a metastore instance only once per test class to make things faster. The intermittent test failure was due to the fact that, in Hive3, the hive conf properties you set on the HiveRunner shell were not passed down from HiveRunner to all the threads spawned inside it (e.g. `HiveMaterializedViewsRegistry`) during HS2 initialization. This meant that these threads were calling`ObjectStore#setConf` with a different set of jdo properties than the rest, leading to the closure and replacement of the global `ObjectStore#PersistenceManagerFactory` instance whenever a config change was detected (-- resulting in intermittent "Persistence Manager has been closed" errors for those threads that would still be using their cached, but now closed PMs). Fortunately, during `HiveConf` construction, all the system properties are surveyed and included so we can ensure that the `metastore_uris` property is properly propagated and get the desired behaviour. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
