kevinjqliu commented on code in PR #2218: URL: https://github.com/apache/iceberg-python/pull/2218#discussion_r2216915128
########## vendor/Makefile: ########## @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# Makefile for generating vendor packages + +.PHONY: all clean fb303 hive-metastore + +all: fb303 hive-metastore + +# FB303 Thrift client generation +fb303: + rm -f /tmp/fb303.thrift + rm -rf fb303 + curl -s https://raw.githubusercontent.com/apache/thrift/master/contrib/fb303/if/fb303.thrift > /tmp/fb303.thrift + rm -rf /tmp/gen-py/ + thrift -gen py -o /tmp/ /tmp/fb303.thrift + mv /tmp/gen-py/fb303 fb303 + +# Hive Metastore Thrift definition generation +hive-metastore: + rm -rf /tmp/hive + mkdir -p /tmp/hive/share/fb303/if/ + curl -s https://raw.githubusercontent.com/apache/thrift/master/contrib/fb303/if/fb303.thrift > /tmp/hive/share/fb303/if/fb303.thrift Review Comment: i was thinking about that too. the `fb303.thrift` here is in the `apache/thrift` repo, which has its own versioning. Its currently on `v0.22.0`. See https://github.com/apache/thrift/tags `hive_metastore.thrift` below is in the `apache/hive` repo which uses hive version. Its currently on `4.0.1`. See https://github.com/apache/hive/tags Its hard to figure out which version we should pick here for each. This might be left to the person upgrading the `vendor/` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
