Guosmilesmile commented on code in PR #13609:
URL: https://github.com/apache/iceberg/pull/13609#discussion_r2218902051
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -109,8 +109,8 @@ public void write(DynamicRecordInternal element, Context
context)
// TODO: Handle precedence correctly for the write
properties coming from
// the sink conf and from the table defaults
Map<String, String> tableWriteProperties =
- Maps.newHashMap(commonWriteProperties);
- tableWriteProperties.putAll(table.properties());
+ Maps.newHashMap(table.properties());
+ tableWriteProperties.putAll(commonWriteProperties);
Review Comment:
The Map<String, String> tableWriteProperties is passed multiple times to
other classes within RowDataTaskWriterFactory. Changing it to use
FlinkConfParser would involve significant modifications, especially since some
places have special logic for tableWriteProperties.
Alternatively, could we add a new method Map<String, String> properties() in
FlinkConfParser to handle priority uniformly?
Do you have any better suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
