zeroshade commented on code in PR #491:
URL: https://github.com/apache/iceberg-go/pull/491#discussion_r2219940662
##########
table/updates.go:
##########
@@ -462,3 +468,35 @@ func NewRemoveSnapshotRefUpdate(ref string)
*removeSnapshotRefUpdate {
func (u *removeSnapshotRefUpdate) Apply(builder *MetadataBuilder) error {
return fmt.Errorf("%w: %s", iceberg.ErrNotImplemented,
UpdateRemoveSnapshotRef)
}
+
+type removeSpecUpdate struct {
+ baseUpdate
+ SpecIds []int64 `json:"spec-ids"`
+}
+
+func NewRemoveSpecUpdate(specIds []int64) Update {
Review Comment:
same as above, convention is to return the concrete type instead of the
interface
##########
table/updates.go:
##########
@@ -462,3 +468,35 @@ func NewRemoveSnapshotRefUpdate(ref string)
*removeSnapshotRefUpdate {
func (u *removeSnapshotRefUpdate) Apply(builder *MetadataBuilder) error {
return fmt.Errorf("%w: %s", iceberg.ErrNotImplemented,
UpdateRemoveSnapshotRef)
}
+
+type removeSpecUpdate struct {
+ baseUpdate
+ SpecIds []int64 `json:"spec-ids"`
+}
+
+func NewRemoveSpecUpdate(specIds []int64) Update {
+ return &removeSpecUpdate{
+ baseUpdate: baseUpdate{ActionName: UpdateRemoveSpec},
+ SpecIds: specIds,
+ }
+}
+
+func (u *removeSpecUpdate) Apply(builder *MetadataBuilder) error {
+ return fmt.Errorf("%w: %s", iceberg.ErrNotImplemented, UpdateRemoveSpec)
+}
+
+type removeSchemasUpdate struct {
+ baseUpdate
+ SchemaIds []int64 `json:"schema-ids"`
+}
+
+func NewRemoveSchemasUpdate(specIds []int64) Update {
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
