nastra commented on code in PR #13613:
URL: https://github.com/apache/iceberg/pull/13613#discussion_r2220010308
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/DataFrameWriteTestBase.java:
##########
@@ -98,7 +98,7 @@ private Dataset<Row> createDataset(List<GenericData.Record>
records, Schema sche
}
// verify that the dataframe matches
- assertThat(rows.size()).isEqualTo(records.size());
+ assertThat(rows).hasSize(records.size());
Review Comment:
```suggestion
assertThat(rows).hasSameSizeAs(records);
```
the advantage here is that this will also show the content of
actual/expected when the assertion ever fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
