wgtmac commented on code in PR #132:
URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2220886443
##########
src/iceberg/transform_function.cc:
##########
@@ -48,7 +52,32 @@ Result<ArrowArray> BucketTransform::Transform(const
ArrowArray& input) {
}
Result<std::shared_ptr<Type>> BucketTransform::ResultType() const {
- return NotImplemented("BucketTransform::result_type");
+ auto src_type = source_type();
+ switch (src_type->type_id()) {
Review Comment:
Shouldn't we check this in the Make function and blindly return `int32()`
here? We can add `static bool BucketTransform::Accepts(const
std::shared_ptr<Type>& source_type)`. I'm open to discuss this but not a
blocker for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
