rdblue commented on a change in pull request #1558:
URL: https://github.com/apache/iceberg/pull/1558#discussion_r501879532
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/FlinkCatalogTestBase.java
##########
@@ -100,6 +100,8 @@ public FlinkCatalogTestBase(String catalogName, String[]
baseNamespace) {
config.put("type", "iceberg");
config.put(FlinkCatalogFactory.ICEBERG_CATALOG_TYPE, isHadoopCatalog ?
"hadoop" : "hive");
config.put(FlinkCatalogFactory.HADOOP_WAREHOUSE_LOCATION, "file:" +
warehouse);
+ String path =
this.getClass().getClassLoader().getResource("hive-site.xml").getPath();
+ config.put(FlinkCatalogFactory.HIVE_SITE_PATH, path);
Review comment:
I think this only works because the file is in the local FS for tests,
and the FS is assumed to be "file" when there is no scheme. I don't think this
is right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
