talatuyarer commented on code in PR #2072:
URL: https://github.com/apache/iceberg-python/pull/2072#discussion_r2224020522
##########
pyiceberg/catalog/rest/auth.py:
##########
@@ -187,3 +217,4 @@ def create(cls, class_or_name: str, config: Dict[str, Any])
-> AuthManager:
AuthManagerFactory.register("noop", NoopAuthManager)
AuthManagerFactory.register("basic", BasicAuthManager)
AuthManagerFactory.register("legacyoauth2", LegacyOAuth2AuthManager)
+AuthManagerFactory.register("google", GoogleAuthManager)
Review Comment:
I can not see any code change to call Google authmanager. This line always
create legacyauthmanager:
https://github.com/apache/iceberg-python/blob/4cac6910667899238a750adc560f317f62718f82/pyiceberg/catalog/rest/__init__.py#L250
##########
pyiceberg/catalog/rest/auth.py:
##########
@@ -187,3 +217,4 @@ def create(cls, class_or_name: str, config: Dict[str, Any])
-> AuthManager:
AuthManagerFactory.register("noop", NoopAuthManager)
AuthManagerFactory.register("basic", BasicAuthManager)
AuthManagerFactory.register("legacyoauth2", LegacyOAuth2AuthManager)
+AuthManagerFactory.register("google", GoogleAuthManager)
Review Comment:
@rambleraptor I can not see any code change to call Google authmanager. This
line always create legacyauthmanager:
https://github.com/apache/iceberg-python/blob/4cac6910667899238a750adc560f317f62718f82/pyiceberg/catalog/rest/__init__.py#L250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
