pvary commented on code in PR #13626:
URL: https://github.com/apache/iceberg/pull/13626#discussion_r2224815370


##########
api/src/main/java/org/apache/iceberg/types/Comparators.java:
##########
@@ -149,6 +155,51 @@ public int compare(List<T> o1, List<T> o2) {
     }
   }
 
+  private static class MapComparator<K, V> implements Comparator<Map<K, V>> {
+    private final Comparator<K> keyComparator;
+    private final Comparator<V> valueComparator;
+    private final Comparator<List<K>> keyListComparator;
+
+    private MapComparator(Types.MapType mapType) {
+      this.keyComparator = internal(mapType.keyType());

Review Comment:
   Good point!
   Thanks for catching!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to