amogh-jahagirdar commented on code in PR #13614:
URL: https://github.com/apache/iceberg/pull/13614#discussion_r2227263522
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -390,4 +391,60 @@ private void cleanExpiredSnapshots() {
cleanupStrategy.cleanFiles(base, current);
}
+
+ private void validateCleanupCanBeIncremental(TableMetadata current) {
+ if (specifiedSnapshotId) {
+ throw new UnsupportedOperationException(
+ "Cannot clean files incrementally when snapshot IDs are specified");
+ }
+
+ if (!onlyRefIsMain(current)) {
+ throw new UnsupportedOperationException(
+ "Cannot incrementally clean files for tables with more than 1 ref");
+ }
+
+ if (!onlyBranchIsMain(base)) {
+ throw new UnsupportedOperationException(
+ "Cannot incrementally clean files when metadata before expiration
has other branches");
+ }
Review Comment:
Need a test case for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
