DerGut commented on code in PR #1549:
URL: https://github.com/apache/iceberg-rust/pull/1549#discussion_r2230473489
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -289,12 +293,31 @@ impl Catalog for MemoryCatalog {
.build()
}
- /// Update a table to the catalog.
- async fn update_table(&self, _commit: TableCommit) -> Result<Table> {
- Err(Error::new(
- ErrorKind::FeatureUnsupported,
- "MemoryCatalog does not currently support updating tables.",
- ))
+ /// Update a table in the catalog.
+ async fn update_table(&self, commit: TableCommit) -> Result<Table> {
+ let mut root_namespace_state = self.root_namespace_state.lock().await;
+
+ // Updates the current table version and writes a new metadata file.
Review Comment:
This is not really what's happening in the line below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
