lidavidm commented on code in PR #156:
URL: https://github.com/apache/iceberg-cpp/pull/156#discussion_r2234367958
##########
src/iceberg/transform_function.cc:
##########
@@ -51,6 +60,57 @@ Result<ArrowArray> BucketTransform::Transform(const
ArrowArray& input) {
return NotImplemented("BucketTransform::Transform");
}
+Result<std::optional<Literal>> BucketTransform::Transform(const Literal&
literal) {
+ assert(literal.type() == source_type());
+ if (literal.IsBelowMin() || literal.IsAboveMax()) {
+ return InvalidArgument(
+ "Cannot apply bucket transform to literal with value {} of type {}",
+ literal.ToString(), source_type()->ToString());
+ }
+ int32_t hash_value = 0;
+ switch (source_type()->type_id()) {
Review Comment:
Right, but in this particular case, the "logical" type doesn't matter,
right? The only thing that matters is the "physical" data type, so you could
use std::visit + static_assert to enforce that all branches are taken without
having to list out each Iceberg type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
