gabeiglio commented on code in PR #1521:
URL: https://github.com/apache/iceberg-rust/pull/1521#discussion_r2234667183
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -745,10 +749,86 @@ impl Catalog for RestCatalog {
_table_ident: &TableIdent,
_metadata_location: String,
) -> Result<Table> {
- Err(Error::new(
- ErrorKind::FeatureUnsupported,
- "Registering a table is not supported yet",
- ))
+ let context = self.context().await?;
+
+ let request = context
+ .client
+ .request(
+ Method::POST,
+ context
+ .config
+ .register_table_endpoint(_table_ident.namespace()),
+ )
+ .json(&RegisterTableRequest {
+ name: _table_ident.name.clone(),
+ metadata_location: _metadata_location.clone(),
+ })
+ .build()?;
+
+ let http_response = context.client.query_catalog(request).await?;
+
+ let response: LoadTableResponse = match http_response.status() {
+ StatusCode::OK => {
+
deserialize_catalog_response::<LoadTableResponse>(http_response).await?
+ }
+ StatusCode::BAD_REQUEST => {
+ return Err(Error::new(
+ ErrorKind::Unexpected,
+ "Unexpected error while registering table.",
+ ));
+ }
+ StatusCode::UNAUTHORIZED => {
+ return Err(Error::new(
+ ErrorKind::Unexpected,
+ "Authenticated user does not have the necessary
permissions.",
+ ));
+ }
+ StatusCode::FORBIDDEN => {
+ return Err(Error::new(
+ ErrorKind::Unexpected,
+ "Authenticated user does not have the necessary
permissions.",
+ ));
+ }
+ StatusCode::NOT_FOUND => {
+ return Err(Error::new(
+ ErrorKind::NamespaceNotFound,
+ "The namespace specified does not exist.",
+ ));
+ }
+ StatusCode::CONFLICT => {
+ return Err(Error::new(
+ ErrorKind::TableAlreadyExists,
Review Comment:
The Rest Spec defines for `registerTable` that a 409 should be a
[TableAlreadyExists](https://editor-next.swagger.io/?url=https://raw.githubusercontent.com/apache/iceberg/main/open-api/rest-catalog-open-api.yaml#:~:text=No%20links-,409,-Conflict%20%2D%20The%20table),
and also I am unsure why this would be a retryable error? Operations that
create a resource (like table or namespace) do not currently mark a 409 as
retryable, which make sense since if the table already exists there is no gain
in retrying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
