pvary commented on code in PR #13562:
URL: https://github.com/apache/iceberg/pull/13562#discussion_r2236826840
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -508,6 +433,179 @@ public static VectorizedReader<?>
replaceWithMetadataReader(
return reader;
}
+ private final class VectorizedArrowReaderLogicalTypeAnnotationVisitor
+ implements LogicalTypeAnnotation.LogicalTypeAnnotationVisitor<Object> {
+ private final Field arrowField;
+ private final PrimitiveType primitive;
+
+ VectorizedArrowReaderLogicalTypeAnnotationVisitor(Field arrowField,
PrimitiveType primitive) {
+ this.arrowField = arrowField;
+ this.primitive = primitive;
+ }
+
+ @Override
+ public Optional<Object> visit(
+ LogicalTypeAnnotation.StringLogicalTypeAnnotation stringLogicalType) {
+ return visitEnumJsonBsonString();
+ }
+
+ @Override
+ public Optional<Object>
visit(LogicalTypeAnnotation.EnumLogicalTypeAnnotation enumLogicalType) {
+ return visitEnumJsonBsonString();
+ }
+
+ @Override
+ public Optional<Object>
visit(LogicalTypeAnnotation.UUIDLogicalTypeAnnotation uuidLogicalType) {
+ // Fallback to allocation based on primitive type name
+ VectorizedArrowReader.this.allocateVectorBasedOnTypeName(
+ VectorizedArrowReader.this.columnDescriptor.getPrimitiveType(),
arrowField);
Review Comment:
the requirement is using `this` when assigning instance variables. See:
https://iceberg.apache.org/contribute/#accessing-instance-variables
In this case it is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
