amogh-jahagirdar commented on code in PR #13614:
URL: https://github.com/apache/iceberg/pull/13614#discussion_r2236915300
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1107,21 +1158,23 @@ public void
testIncrementalCleanupFailsWhenExpiringSnapshotId() {
@TestTemplate
public void testMultipleRefsAndCleanExpiredFilesFailsForIncrementalCleanup()
{
+ assumeThat(incrementalCleanup).isTrue();
+
table.newAppend().appendFile(FILE_A).commit();
table.newDelete().deleteFile(FILE_A).commit();
- table.manageSnapshots().createTag("TagA",
table.currentSnapshot().snapshotId()).commit();
- waitUntilAfter(table.currentSnapshot().timestampMillis());
- RemoveSnapshots removeSnapshots = (RemoveSnapshots)
table.expireSnapshots();
Review Comment:
This had to change because now for this case we're being a bit more
permissive. Previously any ref existiing would lead to a failure but this test
was setting up a tag on main which got aged off. With the new logic we'd allow
incremental cleanup here since the tag is on main and we can use incremental
cleanup safely here. I updated the test so that it creates a branch and writes
to the branch which is then aged off. The check that there are no snapshots
being removed outside of main will fail in the new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
