huaxingao commented on code in PR #13665:
URL: https://github.com/apache/iceberg/pull/13665#discussion_r2238015443


##########
spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/TestRoundTrip.java:
##########
@@ -172,6 +176,34 @@ public void showView() {
     sql("DROP VIEW %s", "test");
   }
 
+  @TestTemplate
+  public void testDecimalColumn() {
+    int rows = 100;
+    String tableName = tableName("decimal_table1");

Review Comment:
   Shall we use the class level field `this.tableName` instead?
   ```
   this.tableName = tableName("decimal_table1");
   ```
   then we will have the  `@AfterEach` cleanup
    `sql("DROP TABLE IF EXISTS %s", tableName)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to