kbendick commented on a change in pull request #1573:
URL: https://github.com/apache/iceberg/pull/1573#discussion_r502754781
##########
File path: build.gradle
##########
@@ -237,6 +237,21 @@ project(':iceberg-data') {
}
}
+project(':iceberg-aws') {
+ dependencies {
+ compile project(':iceberg-api')
+ compile project(':iceberg-core')
+
+ compileOnly "com.amazonaws:aws-java-sdk-core"
Review comment:
Are you sure that this is needed?
I was able to open this PR, remove this line, run `./gradlew clean build`,
and everything passed just fine for me.
All of your imports are from `com.amazonaws.services.s3.*` so I really don't
think that core is needed, but gradle isn't my primary build tool at work so
maybe I'm missing something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
