Fokko commented on issue #2270: URL: https://github.com/apache/iceberg-python/issues/2270#issuecomment-3152157275
Hey @FredKhayat Thanks for raising this. Are you interested in adding these features? For the timestamp nanoseconds: We need to extend [_ConvertToIceberg](https://github.com/apache/iceberg-python/blob/14ee8da8ff73864b271396853aa2ea5e3e3a04b3/pyiceberg/io/pyarrow.py#L1218-L1220) to also pass in the table version, that can be passed in explicitly through the `format-version` table property, or take the `DEFAULT_FORMAT_VERSION` constant. For V3 tables, we can directly convert into nanoseconds, and we can skip the downscaling to microseconds. For the timezones, I'm not sure why this is not allowed. While everyone should avoid using timezones at all to keep everyone sane. In the case you want to use it, we can convert from a timestamp that has a timezone, we should return `TimestamptzType` instead: https://github.com/apache/iceberg-python/blob/14ee8da8ff73864b271396853aa2ea5e3e3a04b3/pyiceberg/types.py#L751-L762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
