pvary commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2255226439
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -155,42 +171,28 @@ public static WriteBuilder write(EncryptedOutputFile
file) {
}
}
+ /**
+ * @deprecated Since 1.10.0, will be removed in 1.11.0. Use {@link
+ * FormatModelRegistry#writeBuilder(FileFormat, String,
EncryptedOutputFile)} instead.
+ */
+ @Deprecated
Review Comment:
We could not do this, because of the decision we made about changing the
`WriteBuilder` to generics.
In the previous `WriterBuilder` only the build method was generic:
```
<D> FileAppender<D> build() throws IOException;
```
On the new API, the `WriterBuilder` is generic instead:
```
/*
...
* @param <D> the input data type for the writer
*/
public interface WriteBuilder<B extends WriteBuilder<B, D>, D> {
```
Since the method parameters are clashing, we can't implement the new
interface with the old class.
My intention was to clean-up the many deprecated methods from the old API
anyway, and provide a new, clean interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
