nastra commented on code in PR #13740:
URL: https://github.com/apache/iceberg/pull/13740#discussion_r2256567456
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSnapshotUpdateSparkAction.java:
##########
@@ -38,10 +39,12 @@ public ThisT snapshotProperty(String property, String
value) {
protected void commit(org.apache.iceberg.SnapshotUpdate<?> update) {
summary.forEach(update::set);
+ update.set(SparkWriteUtil.SPARK_APP_ID,
spark().sparkContext().applicationId());
Review Comment:
all of this is already automatically handled via `EnvironmentContext`. It's
handled at
https://github.com/apache/iceberg/blob/3e0f7a1bfb167c4d18ebdc9d0f69afe0f4754512/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java#L778
and then added to the summary in
https://github.com/apache/iceberg/blob/be577eeac631d77243beb57409e476bf197f79d7/core/src/main/java/org/apache/iceberg/SnapshotProducer.java#L409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
