zeroshade commented on code in PR #524: URL: https://github.com/apache/iceberg-go/pull/524#discussion_r2263772142
########## schema_conversions.go: ########## @@ -30,33 +30,35 @@ func partitionTypeToAvroSchema(t *StructType) (avro.Schema, error) { var sc avro.Schema switch typ := f.Type.(type) { case Int32Type: - sc = internal.IntSchema + sc = internal.NullableSchema(internal.IntSchema) Review Comment: Can we add a test case for this then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org