JeonDaehong commented on PR #13771: URL: https://github.com/apache/iceberg/pull/13771#issuecomment-3172271835
> @JeonDaehong Thank you very much for your PR! Regarding the documentation part, I feel there are a few points that need to be discussed: > > 1. A new md file was added but not included in mkdocs.yml. I think this page will not take effect. I feel it might be unnecessary to add a new page; instead, we could add the content to the existing flink-actions.md, distinguishing between streaming and batch. However, this is just my personal opinion, and I would like to hear @pvary Peter’s thoughts. > 2. Could we add a section about which table maintenance operations Flink currently supports, what their purposes are, and describe the corresponding configurations within each relevant feature, rather than putting all configurations in one section? > 3. Regarding the locking part, there is no Java API configuration provided; the configuration options given are for SQL, and SQL only uses them when compaction is enabled in sink v2. I suggest separating this and describing it in an independent section. @Guosmilesmile Thank you for your feedback. Based on your comments, I will make the necessary changes and commit them again. First, I will continue adding the content to the flink-table-maintenance.md file and update the mkdocs.yml file accordingly. If @pvary prefers the content to be appended to flink-action.md instead, I will revise it and move it there at that time. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
