RussellSpitzer commented on a change in pull request #1525: URL: https://github.com/apache/iceberg/pull/1525#discussion_r503362964
########## File path: spark3/src/main/java/org/apache/iceberg/spark/CreateActions.java ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark; + +import org.apache.spark.sql.SparkSession; +import org.apache.spark.sql.connector.catalog.Identifier; + +public class CreateActions { Review comment: If we wanted the most limited api I think we want Migrate - Takes one arg (identifier) Snapshot - Takes two args (identifier source, identifier dest, location) I'm a little worried about having a "snapshot" verb with "as" since I feel like it also requires an "at" for a location and then I have to do a runtime check to make sure they are both used unless I make a series of chaining classes. SnapshotStart --- .as(identifier) --> SnapshotWithDest --- at(location) --> CreateAction Although I'm ok with that too, that's probably more complicated for us, but more difficult for an end user to use incorrectly or get an unexpected result from. This would be the minimal setup then, I'm not sure what createTable like would do? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
